Skip to content
This repository was archived by the owner on Nov 6, 2023. It is now read-only.

Updated Meetup.xml - #4371

Merged
fuglede merged 7 commits into
EFForg:masterfrom
J0WI:meetup
Aug 22, 2016
Merged

fuglede merged 7 commits into
EFForg:masterfrom
J0WI:meetup

Conversation

@J0WI

@J0WI J0WI commented Mar 15, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@funkydude

Copy link
Copy Markdown
Contributor

hep.meetup.com

I think you mean help

<rule from="^http://meetup\.com/" to="https://www.meetup.com/" />

You should also forward https requests so from="^https?://meetup\.com/"

Same goes for from="^http://(photos|static)\d\.meetupstatic\.com/"

@J0WI

J0WI commented Mar 17, 2016

Copy link
Copy Markdown
Contributor Author

Thanks for exposing the typo.

You should also forward https requests so from="^https?://meetup.com/"

Disagree, see discussion in #4303. There is no use case, except the page uses weird redirects or a domain is deprecated, but still linked on many third party sites.

@funkydude

Copy link
Copy Markdown
Contributor

Oh please, @fuglede contradicts himself on a daily basis. One day he says he doesn't see the point of cookie rules, the next day he is using them himself. He himself has redirected https rules previously.

I will personally opt to continue this "extra maintenance" (nonsense, he doesn't even provide any examples of any negatives) to give the user a complete experience. There is no way of knowing who might link said domain or type it manually.

@J0WI J0WI mentioned this pull request May 9, 2016
@J0WI J0WI added this to the Before the Next Release milestone May 11, 2016
@Hainish Hainish added the top-1k label Aug 19, 2016
@J0WI

J0WI commented Aug 21, 2016 •

Copy link
Copy Markdown
Contributor Author

Would be great to have this merged @fuglede @jeremyn

@J0WI J0WI closed this Aug 21, 2016
@J0WI J0WI reopened this Aug 21, 2016
@fuglede

fuglede commented Aug 21, 2016

Copy link
Copy Markdown
Contributor

Looks good to me; I could not find any issues. Would you be able to provide some examples/test URLs for the static\d/photos\d parts of the ruleset? It was not clear to me why the counter stops at 4.

@J0WI

J0WI commented Aug 21, 2016

Copy link
Copy Markdown
Contributor Author

@fuglede I've updated the regex and the test urls. There are only numbers 1 to 4.

@fuglede

fuglede commented Aug 22, 2016

Copy link
Copy Markdown
Contributor

Perfect, thanks! I'm a bit confused about the different roles that photos and static play on their site, but that's what it is.

@fuglede
fuglede merged commit 9e0fa03 into EFForg:master Aug 22, 2016
@J0WI
J0WI deleted the meetup branch August 22, 2016 22:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants